Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] 【feedbackTextError】当有自定义validator + 默认的validator时提示文案出错 #4129

Open
1 task
KedAyAyA opened this issue Apr 7, 2024 · 1 comment

Comments

@KedAyAyA
Copy link

KedAyAyA commented Apr 7, 2024

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

当定义了自定义的validator 和 默认的 required之后,错误提示文案会出现 [errormessage1], , ,[errormessage2] 的非预期文案

What is expected?

错误提示文案应为 [errormessage1],[errormessage2]

What is actually happening?

源码上看,应该是这行 https://github.com/formilyjs/element-plus/blob/main/packages/components/src/form-item/index.ts#L524 中,已经为每个错误信息增加了分隔符

但是这行又join了 ', ' https://github.com/formilyjs/element-plus/blob/main/packages/components/src/form-item/index.ts#L537 ,就导致了 ['error1', ',' , 'error2'].join(', ') => error1, , , error2,辛苦看下是否是这个问题,是的话我提PR了

Package

@formily/element-plus@1.1.0.beta


@KedAyAyA
Copy link
Author

这个库是没人维护了吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant