Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Cmake scripts #60

Open
1 of 2 tasks
ChuanqiXu9 opened this issue Mar 10, 2022 · 0 comments
Open
1 of 2 tasks

Broken Cmake scripts #60

ChuanqiXu9 opened this issue Mar 10, 2022 · 0 comments

Comments

@ChuanqiXu9
Copy link
Collaborator

Search before asking

  • I searched the issues and found no similar issues.

What happened + What you expected to happen

Extract from https://www.reddit.com/r/cpp/comments/ta4h29/async_simple_a_c20_coroutine_library/

- C++20 support was added in 3.12, this project wrongly requires 3.8
- Pulling in dependencies on the main code path for developer requirements (tests, benchmarks)
- Setting user-settable variables (CMAKE_BUILD_TYPE which is also completely ignored by multi-config generators)
- Hardcoding flags (put them in a toolchain/preset)
- Lack of install interface

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant