Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using estring_view instead of std::string_view for APIs, to avoid ABI inconsistency between C++ versions #277

Open
lihuiba opened this issue Nov 24, 2023 · 0 comments

Comments

@lihuiba
Copy link
Collaborator

lihuiba commented Nov 24, 2023

We make extensive use of string_view for efficient handling of strings. And we use it in C++14 mode by cheating std library, and let it think we are in c++17 mode. This compiles OK, but leads to ABI inconsistency in binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant