Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI #2

Open
peckjon opened this issue Jun 16, 2017 · 1 comment
Open

Set up CI #2

peckjon opened this issue Jun 16, 2017 · 1 comment
Assignees

Comments

@peckjon
Copy link
Contributor

peckjon commented Jun 16, 2017

Let's add CI so we don't have to manually build each time.

PUBLISH.md holds the env setup info.

Build script would simply be:

grunt build:image-tagger
grunt build:colorize-photos
grunt build:classify-places
grunt build:deep-fashion
grunt build:deep-style
grunt build:web-page-inspector
grunt build:video-search
grunt build:rss-dashboard
grunt build:sitemap
grunt build:timeseries
grunt build:isitnude
grunt build:video-toolbox
grunt build:video-metadata

@anowell my usual tendency is to add a publish branch but AFAIK you prefer CI to run off master and for us to create a dev or feature-branches instead?

@anowell
Copy link
Contributor

anowell commented Jun 16, 2017

Re-publishing all demos every time seems a bit heavy-handed. :-/ But trying to find the right subset feels a bit complex, so I don't have a better idea at the moment.

Re: master vs publish - I just like the philosophy of "keep master shippable". Plus, the PR workflow works slightly better with that then with a separate publish branch, but if not-deployable stuff is getting into master, switching to a publish branch as an extra gate seems reasonable. (Platform actually uses a prod branch for this purpose, and we try to keep master in sync with test.)

@anowell anowell removed their assignment Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants