Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments with null points and different order than HN #206

Open
ig-perez opened this issue Apr 10, 2021 · 5 comments
Open

Comments with null points and different order than HN #206

ig-perez opened this issue Apr 10, 2021 · 5 comments

Comments

@ig-perez
Copy link

Hi,

Thanks for maintaing this repo. I have noticed comments from a given item return with points: null, probably this is causing the comments are not returned in the same order as when querying HN. For example:

https://hn.algolia.com/api/v1/items/26750452
https://news.ycombinator.com/item?id=26750452

Thanks

@pierregoutheraud
Copy link

pierregoutheraud commented Sep 16, 2022

Is this project still maintained?
Sorting comments by popularity is still broken :'(

@JonasBa
Copy link
Contributor

JonasBa commented Sep 19, 2022

cc @Haroenv anyone that could take a look at this?

@julienpa
Copy link
Contributor

Hi @ig-perez @JonasBa, the issue in the initial comment seems to be fixed (both link show the same number of points).

@pierregoutheraud could you elaborate? Do you have an example where it's not working? Selecting "Comments" and leaving the default sorting "Popularity" seems to work (tried searching as well):
All  Search powered by Algolia 2022-09-27 at 11 58 36 AM

@ig-perez
Copy link
Author

Cool, thanks @julienpa . @pierregoutheraud feel free to close the issue if works for you as well.

Best,
Ivan

@Haroenv Haroenv closed this as completed Sep 29, 2022
@pierregoutheraud
Copy link

pierregoutheraud commented Oct 3, 2022

@julienpa When sorting comments by popularity "All time" time range works but any other time range returns the same results:

Screen.Recording.2022-10-03.at.23.26.22.mov

This might be because hackernews api does not return the score for comments anymore.

@Haroenv Haroenv reopened this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants