fix(tests): fix check of autoloaders #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikeastock @vvo don't hesitate to provide your feedbacks on this PR as well! I'm not sure it's the most efficient way of fixing our error |
chloelbn
force-pushed
the
fix/zeitwerk-call
branch
from
f122390
to
6090a66
Compare
|
Fixed with #392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
In order for the app to be able to use Zeitwerk autoloading, a fix was made in the class loader. However, as the condition did not check if application was running before anything else, it triggered a
undefined methodconfig' for nil:NilClassonRails.application`. We now check first that the application is correctly running before making use of autoloadingThis fixes the failing CI for Rails 6