Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default "else" catchall config does not set FACTORY_DEFAULT_PIN mode for Long Press #488

Open
Pedalnetics opened this issue Jan 3, 2024 · 3 comments

Comments

@Pedalnetics
Copy link
Sponsor

Firmware 3.2.0, Config.h, Line ~990 where it's setting up the default Actions for the onboard button for Profile+, Profile-, and Device Info, it's never setting the PEDALS-1 button to be PED_PRESS_1_2_L, therefor the LONG press to show device info is not working and you can't get to see the IP address of the device.

I fixed it in my local code by adding the following, not sure if it's the right fix or not but it did what I needed:
pedals[PEDALS-1].pressMode = PED_PRESS_1_2_L;

@alf45tar
Copy link
Owner

alf45tar commented Jan 3, 2024

Not sure if I got it.
The long press works for me in my T-Display and T-Display-S3 board. Your suggested fix is exactly the 990 line.

@Pedalnetics
Copy link
Sponsor Author

Pedalnetics commented Jan 3, 2024

Sorry, mixed up my lines.
Correct, the ttgo stuff is getting caught in the If on line 962 then setting that default pedal mode for pedals-1 on 990 (and/or the if on 866 & mode on 895)
For other boards not caught on 866 or 962, they hit the else on 1056, and need that fix around 1084 I believe;

Context: My Heltec is coming up factory default without Long Press enabled on the onboard button even though the default Actions are there to try and show Device Info with a long press. Copying that line from 990 down to 1084 solved it for me.

@Pedalnetics
Copy link
Sponsor Author

If there is a way I can privately fork the sponsors repo and submit pull requests to it, I'd be happy to submit some of these fixes/other features. Along with this I have the heltec v3 board working, some display pedal-tag enhancements related to the rectangle-block drawing, and have some other features I'll be coding like a sequence-reset command. but as it sits, I can't pull-request those back since I'm working off the newer sponsors code base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants