Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving resources to resource bundle #82

Open
OneSman7 opened this issue Jan 15, 2021 · 3 comments
Open

Moving resources to resource bundle #82

OneSman7 opened this issue Jan 15, 2021 · 3 comments

Comments

@OneSman7
Copy link

OneSman7 commented Jan 15, 2021

Hello @justindhill!
You wrote that you still come here from time to time to maintain the repository.
This is a wonderful and simple library with many ready-to-go integrations that we are to this day using in our app.

We want to optimise our pod installation process: at the times of Xcode 10 we had to add :disable_input_output_paths => true to Podfile to mitigate CocoaPods/CocoaPods#8122. These days we found that every other pod moved to using resources_bundle except this one. I wrote a simple PR ( #81 ) to fix this. It would be cool if you could merge it and add version 1.7.2 tag to the master branch.

Thank you in advance!

@justindhill
Copy link
Contributor

Hi @OneSman7, I'll try to have a look at this tonight and get it merged. Thanks for the PR!

@OneSman7
Copy link
Author

OneSman7 commented Feb 5, 2021

hello again! any news?

@OneSman7
Copy link
Author

OneSman7 commented Feb 8, 2021

@justindhill also edited FLAnimatedImage module import to support the latest version in PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants