Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freezes on action button #71

Open
abdullahumer opened this issue Nov 6, 2019 · 4 comments
Open

Freezes on action button #71

abdullahumer opened this issue Nov 6, 2019 · 4 comments

Comments

@abdullahumer
Copy link

Hi

My app is freezing when tapped on the action and if save is selected from the action sheet.

The dismiss button and swipe also stops working.

@kyoji2
Copy link

kyoji2 commented Nov 7, 2019

Same here.
I've debug this issue, here is some findings: In iOS 13, dismiss method is called after save image action, which caused the problem. In iOS 12, everything works fine.

kyoji2 added a commit to Sumi-Interactive/AXPhotoViewer that referenced this issue Nov 7, 2019
@abdullahumer
Copy link
Author

Thanks, it works! The app is not freezing now.

I guess the default behaviour was supposed to dismiss the viewController after the save image action is selected but for some reasons, its not working in iOS 13.

My quick guess is that the dismiss should be done on completion of save image operation.

For now, your solution is the best. The users will have to manually close the view by swipe of by using the close button.

@abdullahumer
Copy link
Author

After testing more, I found that the following actions are also causing the same issue:

  • Add to shared Album
  • Save to Files

In case of Save to Files, it takes too long. And if I tap the cancel, it does not close the activityViewController.

And I see an error log: [ShareSheet] cancelled request - error: The operation was cancelled.

@abdullahumer
Copy link
Author

abdullahumer commented Nov 7, 2019

Alright, the cause of the above issues was your work around.

But this code fixes the issue:

        if self.presentedViewController != nil {
        //            super.dismiss(animated: flag, completion: completion)
            self.presentedViewController?.dismiss(animated: flag, completion: {
                completion?()
            })
            return
        }

KarolMajka added a commit to KarolMajka/AXPhotoViewer that referenced this issue Nov 23, 2019
According to this issue alexhillc#71
Change fix freezing problem when permission to gallery was refused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants