Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing assertions on unit tests #333

Open
1 of 6 tasks
sayantandey opened this issue May 13, 2023 · 0 comments
Open
1 of 6 tasks

missing assertions on unit tests #333

sayantandey opened this issue May 13, 2023 · 0 comments

Comments

@sayantandey
Copy link

sayantandey commented May 13, 2023

I'm submitting a...

  • Regression (a behavior that used to work and stopped working in a new release)

  • Bug report

  • Performance issue

  • Feature request

  • Documentation issue or request

  • Other... Please describe:

    Issue with Junits missing assertions which might cause the unit tests to miss potential bugs.
    Missing unit test assertions for ask-sdk-local-debug : RequestResponseUtils

Expected Behavior

  • One or more unit test assertion should fail after the code's logic is changed.
  • One or more unit test should cover default switch case

Current Behavior

  • No assertions error thrown
  • Missing test for default switch case

Steps to Reproduce (for bugs)

  • Check out this PR gh pr checkout 332
  • Run the unit tests by mvn clean test

Possible Solution

  • Add assertions for method invocation for skillInvokerConfiguration of type SKILL_STREAM_HANDLER_TYPE
  • Add additional tests for Unknown skill configuration type

Context

Your Environment

  • ASK Java SDK version used: 1.8
  • Operating System and version: Microsoft Windows [Version 10.0.19044.2846]

Java Info

  • Java version used for development: 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant