Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package adding unnecessary empty divs #41

Open
Sebastp opened this issue Dec 19, 2019 · 6 comments
Open

Package adding unnecessary empty divs #41

Sebastp opened this issue Dec 19, 2019 · 6 comments
Assignees
@alex-cory
Labels
enhancement New feature or request todo Needs to get done

Comments

@Sebastp
Copy link

Sebastp commented Dec 19, 2019

Can we somehow prevent this package from adding empty divs to the end of the body on init?

Untitled-1
@alex-cory
Copy link
Owner

alex-cory commented Dec 19, 2019 •
edited

we can. I've been working on a way to have the portal only have 1 div it's working with for all portals on the page. I just haven't had time yet.

@Sebastp
Copy link
Author

Sebastp commented Dec 19, 2019

we can. I've been working on a way to have the portal only have 1 div it's working with for all portals on the page. I just haven't had time yet.

ok, thanks

@Sebastp Sebastp closed this as completed Dec 19, 2019
@alex-cory alex-cory added enhancement New feature or request todo Needs to get done labels Dec 19, 2019
@Sebastp
Copy link
Author

Sebastp commented Feb 15, 2020

Any news on that? I really need this fixed. Can I help you in any way to make it done?

@Sebastp Sebastp reopened this Feb 15, 2020
@alex-cory
Copy link
Owner

Feel free to submit a PR! Sorry for the delay. I have been crazy busy

@StephenArk30 StephenArk30 mentioned this issue Apr 2, 2022
Closed
@StephenArk30
Copy link

Guys check my pr, this should work.

@StephenArk30
Copy link

btw, I think found an error in the example here, there should be an event passing to the openSecondPortal right? If so I can fix it in my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-cory alex-cory

Labels
enhancement New feature or request todo Needs to get done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alex-cory @Sebastp @StephenArk30