Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow adding files to entity sets #3679

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

tillprochaska
Copy link
Contributor

Fixes #3610.

While it can be useful to add immutable entities (such as documents) to entity sets, entity sets have never really supported that. The entire UI side of entity sets assumes that entity set items can be mutated by users. This led to inconsistencies and bugs. For example, adding a file to an entity set would remove the `contentHash` property, and once added to an entity set, users were able to change properties of files such as the file name.
When expanding an entity in a network diagram, we need to be able to include only non-file entities. This change adds a `schemata` query parameter to the entities expand API endpoint, the endpoint used by the network diagram UI, to enable this.

This change is a little hacky and adds even more complexity to the `expand_proxies` method which already is quite complex. I'm not entirely sure this is a good idea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Adding files to entity sets breaks file previews
1 participant