Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Some web pages don't render #3334

Open
monneyboi opened this issue Sep 26, 2023 · 1 comment · May be fixed by #3335
Open

BUG: Some web pages don't render #3334

monneyboi opened this issue Sep 26, 2023 · 1 comment · May be fixed by #3335
Assignees
@monneyboi
Labels
bug Things that should work, but don’t Moderate Issue that may require attention

Comments

@monneyboi
Copy link
Contributor

monneyboi commented Sep 26, 2023 •
edited

Some HTML documents uploaded to Aleph don't render in the GUI. Not all sites seem to be affected by this. A couple examples:

To Reproduce
Steps to reproduce the behavior:

  1. Safe any article from one of the examples
  2. Upload the HTML file in Aleph
  3. Open the HTML file in Aleph
  4. See nothing

Expected behavior
I expect to see a safe render of the HTML document.

Aleph version
This happens in the OCCRP Aleph instance as well in ours. Aleph on our end is 3.15.1

Screenshots
image

Additional context
The problem seems to be caused by the safeHtml property containing broken html content. The bodyHtml property contains the original document.
@monneyboi monneyboi added bug Things that should work, but don’t triage These issues need to be reviewed by the Aleph team labels Sep 26, 2023
@monneyboi monneyboi linked a pull request Sep 26, 2023 that will close this issue
Open
@monneyboi monneyboi removed the triage These issues need to be reviewed by the Aleph team label Sep 26, 2023
@Rosencrantz Rosencrantz changed the title BUG: Som web pages don't render BUG: Some web pages don't render Oct 24, 2023
@Rosencrantz Rosencrantz added the Moderate Issue that may require attention label Oct 24, 2023
@monneyboi
Copy link
Contributor Author

The PR for this issue has been waiting to be accepted for quite some time now, if that gets merged this bug can be closed.

@tillprochaska tillprochaska mentioned this issue Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monneyboi monneyboi

Labels
bug Things that should work, but don’t Moderate Issue that may require attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move safeHtml to React component. followthemoney/aleph
2 participants
@Rosencrantz @monneyboi