New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - Badge on bookmark icon in sidebar shows there are bookmarks, but there's really none #630
Comments
Hi @garyking , What do you have currently open? A folder, a workspace (multi-root folder) or just random files (no folder)? Also, how many bookmarks appears if you use the
In this case, the Hope this helps |
|
I could reproduce this behavior with the "A smaller file (less lines) and the bookmark is located after its end" scenario. The missing file scenario, on the other hand, presented a small difference (visually speaking). I'll reopen the issue, in order to take a closer look and fix it. The number in the badge should reflect the number of valid bookmarks. Thanks for reporting |
I had this issue when I closed a file with bookmarks. It had 3 bookmarks and the notification said 3 as expected, when I closed the file it still said 3 but opening the bookmarks sidepanel just said "No bookmarks". |
I have identified the timing of the occurrence. For others, it is working as expected. |
When I updated to the latest revision, the bug had been resolved. |
I'm experiencing the same issue with Bookmarks v13.4.2 (on Fedora Linux, codium version 1.87.2), after that a file with a bookmark on it has been renamed by a git commit. The bookmarks list was empty, while the badge was still "1". The command (anyway, thanks for this very useful extension!) |
@zapateo this may be caused by a recent VS Code regression that I have just submitted a PR to fix: |
Environment/version
Steps to reproduce
Per my screenshot below, the badge says there are two bookmarks, but there are really none. In another one of my projects, the badge says 1 but there's no bookmarks. If I add a bookmark, then the badge increases from 2 to 3, and the bookmark appears fine in the sidebar. But again, the count is 2 higher than it should be.
The text was updated successfully, but these errors were encountered: