Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

Intercept UNIX signals #7

Open
albrow opened this issue Apr 15, 2015 · 4 comments
Open

Intercept UNIX signals #7

albrow opened this issue Apr 15, 2015 · 4 comments

Comments

@albrow
Copy link
Owner

albrow commented Apr 15, 2015

Currently, if you cause a worker pool process to quit by sending a UNIX signal (e.g. by pressing ctrl-c), it will quit immediately without waiting for jobs to finish executing. This is good behavior for testing purposes (because it lets me simulate hard failures), but ideally the process should intercept certain types of signals and wait before exiting.

@epelc
Copy link
Contributor

epelc commented May 14, 2015

+1 for this and also for making sure it works when your running in a docker container.

@albrow albrow added this to the Version 0.3.1 milestone May 15, 2015
@albrow
Copy link
Owner Author

albrow commented May 15, 2015

@epelc, thanks for your feedback. I'm targeting this for version 0.3.1. Can you elaborate on what is required in order to be compatible with docker? AFAIK there is nothing that would make it incompatible, but I'm only played around with docker a little.

@epelc
Copy link
Contributor

epelc commented May 15, 2015

@albrow I don't think anything you do would be inherit nay incompatible. I just thought it'd be a good idea to test it with docker.

I'd test that it works with docker stop and possibly docker kill. Let me know if you need any help testing.

@albrow
Copy link
Owner Author

albrow commented May 15, 2015

👌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants