Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clipboard v3.0] Disable warning window xdotool #1377

Open
Base-115 opened this issue Mar 17, 2024 · 15 comments
Open

[clipboard v3.0] Disable warning window xdotool #1377

Base-115 opened this issue Mar 17, 2024 · 15 comments
Assignees

Comments

@Base-115
Copy link

Package source

Ubuntu repository

App report

Albert version: 0.23.0
           Build date: Mar  4 2024 13:27:29
           Qt version: 6.6.2
            Build ABI: x86_64-little_endian-lp64
   Build architecture: x86_64
     CPU architecture: x86_64
          Kernel type: linux
       Kernel version: 6.5.0-25-generic
                   OS: KDE neon 6.0
              OS type: neon
           OS version: 22.04
        Platform name: xcb
           Style name: breeze
     Available styles: Breeze, Windows, Fusion
           Icon theme: breeze-dark
                 Font: Noto Sans,10,-1,0,400,0,0,0,0,0,0,0,0,0,0,1
             Language: English
               Locale: en_US
      Binary location: /usr/bin/albert
          Working dir: /home/matheus
            Arguments: /usr/bin/albert
                $LANG: en_US.UTF-8
$QT_QPA_PLATFORMTHEME: 
                $PATH: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
               $SHELL: /bin/bash
    $XDG_SESSION_TYPE: wayland
 $XDG_CURRENT_DESKTOP: KDE
     $DESKTOP_SESSION: plasma
 $XDG_SESSION_DESKTOP: KDE

Current Behavior

Hi,

I switched to KDE Plasma 6 (Wayland) some days ago and when I use the clipboard feature, actually, when I choose the options and hit "Enter", a warning window spawn tell it "Paste failed. xdotool installed?".

image

Since I'm in Wayland, xdotool doesn't work properly, as far I know, so... Are there some way to disable this message always when I choose an option in clipboard plugin?

Sorry if it stupid question... 😅

Thank you in advance. ❤️

Expected Behavior

When I choose a option "clipboard" and hit "Enter", the warning window about xdotool doesn't spawn.

Since, it already copy to the "clipboard", ready to paste, the only annoying thing is the warning window.

Anything else?

No response

@ManuelSchneid3r
Copy link
Member

ManuelSchneid3r commented Mar 17, 2024

Right. The action should not appear if pasting is not supported. On my list

@Base-115
Copy link
Author

Alright, thank you so much Manuel. ❤️

I forget to mention that this behavior also happens with other plugins, like the "Translator".

@ManuelSchneid3r
Copy link
Member

ManuelSchneid3r commented Mar 17, 2024

BTW xdotool does work on wayland for XWayland windows.

@Base-115
Copy link
Author

Thank you for the tip, I'll check it out.

@rbjorklin
Copy link

Would it be possible to make the clipboard command configurable? I'm using Gpaste and if I could configure Albert to use gpaste-client instead of xdotool that would probably do the trick for me.

@ManuelSchneid3r
Copy link
Member

ManuelSchneid3r commented Mar 20, 2024

Does it do anything better than xdotool? I mean xdotool is okay-ish. The feature is experimental anyway (nifty though). Unfortunately there is no generic paste solution iirc. Wayland breaks things ofc. But xdotool gets the job done right?

@rbjorklin
Copy link

I'm actually entirely unfamiliar with xdotool and after looking at the man page I see they fill two entirely different purposes. What I want is actually a way to configure how things are added/referenced/removed to/from the paste buffer.

@ManuelSchneid3r
Copy link
Member

ManuelSchneid3r commented Mar 20, 2024

Then this is offtopic here clipboard is managed by the QClipboard class in c++. I don't get it. What exactly do you want to achieve?

@fdmarcin
Copy link

As a datapoint, I'm on Fedora GNOME/x11. I get this warning since updating from 0.22.14 to 0.23 but the snippet is still copied to my clipboard, and I don't have xdotool installed.

@ManuelSchneid3r
Copy link
Member

Did you check the actual action you fire? the first one is Copy&Paste the second is only copy.

@fdmarcin
Copy link

Did you check the actual action you fire? the first one is Copy&Paste the second is only copy.

@ManuelSchneid3r If you mean me, I search for the snippet and press Enter. Not sure how to trigger another action.
Previously this only copied the snipped into the clipboard and does this now too. The error message says Paste failed anyway.

@ManuelSchneid3r
Copy link
Member

can i have a screenie? i cant remember that I have changed this.

Bildschirmfoto 2024-03-22 um 16 24 26

@fdmarcin
Copy link

Here's how it looks for me:

image

Config:

image

image

image

@ManuelSchneid3r
Copy link
Member

and when you hold alt?

@fdmarcin
Copy link

fdmarcin commented Mar 22, 2024

and when you hold alt?

@ManuelSchneid3r Then they do appear! 🎉 Like I said, I didn't know about this 😅 This makes editing snippets so much easier.

Anyway, I've installed xdotool now and snippets are pasted correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants