New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Add class Color
#24
Comments
Hi @Erol444 , thanks for using distinctipy! I think I'd be happy for this to be added to distinctipy because I can see some of the benefits, but note that:
But PRs certainly welcome 🙂 |
Draft PR here: #25 Head up: for our project (depthai-sdk) we might fork this to remove dependencies to panda/matplotlib and create a separate library, as we don't require such features (only create unique colors). |
Great, I'll take a look when I have some time (hopefully later this week)
@Erol444 The latest versions of |
I have now noticed I was on the old branch (develop) and that main has had a few updates. Now I see that matplotlib/pandas aren't dependencies anymore, which is perfect! |
I would add a main class
Color
(naming TBD), and the whole library would work with it.eg.
distinct_color()
returnsColor
.color_distance()
takes 2x Color as argument. Thewhy
is that we don't need to create our own helper classes for normalization/color order conversion.Let me know your thoughts, as I (or one of our team members) would like to start working on this.
Thanks, Erik
The text was updated successfully, but these errors were encountered: