MySQL MEDIUMINT not supported in the Types

[Tusamarco]

In the driver type mapping the type MEDIUMINT is missing.
File drv_mysql.c

https://dev.mysql.com/doc/refman/8.0/en/integer-types.html

[dveeden]

Yes it indeed looks like that's missing:

sysbench/src/drivers/mysql/drv_mysql.c

Lines 148 to 151 in db694e7

	{DB_TYPE_TINYINT, MYSQL_TYPE_TINY},
	{DB_TYPE_SMALLINT, MYSQL_TYPE_SHORT},
	{DB_TYPE_INT, MYSQL_TYPE_LONG},
	{DB_TYPE_BIGINT, MYSQL_TYPE_LONGLONG},

This would also require updates in src/db_driver.c (db_print_value) and src/db_driver.h (db_bind_type_t).

@Tusamarco maybe you could create a PR for this?

[dveeden]

The PostgreSQL Docs say that PostgreSQL doesn't have a 3-byte integer, but only has 2, 4 and 8 byte integer types. This might make MEDIUMINT a bit complicated compatibility wise.

Note that there is support for TINYINT, which is 1 byte, but I assume that now uses a byte type or something similar for PG.

sysbench/src/drivers/pgsql/drv_pgsql.c

Lines 75 to 78 in db694e7

	{DB_TYPE_TINYINT, 0},
	{DB_TYPE_SMALLINT, 21},
	{DB_TYPE_INT, 23},
	{DB_TYPE_BIGINT, 20},

[Tusamarco]

Well if not present in PG then when creating a test with MEDIUM int that must be marked as MySQL only.
Because trying to handle it like converting to INT for PG will also means to alter the schema definition when executing and more.
SO in short better to be aware of the limitation upfront and know that the test is limited than trying to catch any possible edge case.
at leas that is my opinion.
@dveeden what you think. (about PR true.. I can)

[dveeden]

Yes fully agree. I think setting this to 0 in drv_pgsql.c, just like DB_TYPE_TINYINT should probably make this fail in PostgreSQL.