Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window x64 platform base_encode outlen is ZERO #40

Open
tomcatter opened this issue May 24, 2017 · 4 comments
Open

Window x64 platform base_encode outlen is ZERO #40

tomcatter opened this issue May 24, 2017 · 4 comments
Labels
bug

Comments

@tomcatter
Copy link

I compiled the library on Windows x64 platform, I specified the sse3 instruction set, then I used it for encode to base64, but the length of the base64 string is zero. I tried the x86, it is working well.
@aklomp
Copy link
Owner

aklomp commented May 31, 2017 •
edited

An output length of zero is a strong indication that the codec is not properly compiled in. Are you using the BASE64_FORCE_SSSE3 flag to force the codec? Because this will only work if the codec is compiled in. By default it's not.

Could you compile and run the test suite and print the output?

@tomcatter
Copy link
Author

Yes, I use this version of base64-0.3.0 release. In the config.h set the HAVE_SSSE3 to 1.

mayeut added a commit to mayeut/base64 that referenced this issue Aug 31, 2017
@mayeut
Do the same checks in codecs than in codec_choose
e516d76 
Conditional code is now only dependent on config.h values in codecs
except for NEON which also includes the same checks as in codec_choose.
This fixes mayeut/pybase64#8 and probably aklomp#40
@mayeut mayeut mentioned this issue Aug 31, 2017
Merged
@aklomp
Copy link
Owner

aklomp commented Sep 13, 2017

Hey, could you please re-test with the latest master branch? The merge of issue #42 may have fixed the bug.

@aklomp aklomp added the bug label Nov 16, 2019
@aklomp
Copy link
Owner

aklomp commented Jan 15, 2024

As of v0.5.2, this library is now built and tested in CI on Windows, by building it with a variety of MSVC and MSYS2/MinGW setups. A number of bugs were also fixed in regard to platform detection and Windows compatibility. Does the bug still happen with the latest release?

I am tempted to close this issue because there is now comprehensive CI coverage for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aklomp @tomcatter