Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: codec_choose_x86 does not check for OS AVX512 support #113

Open
mayeut opened this issue Oct 23, 2022 · 3 comments
Open

bug: codec_choose_x86 does not check for OS AVX512 support #113

mayeut opened this issue Oct 23, 2022 · 3 comments
Assignees
Labels

Comments

@mayeut
Copy link
Contributor

mayeut commented Oct 23, 2022

The check for OS support has not been updated & still only checks for AVX support.
AVX512 added masks, 512-bit register size & 16 new registers. There are 3 corresponding bits that need to be checked in XCR0.

@aklomp aklomp added the bug label Oct 23, 2022
@aklomp aklomp self-assigned this Oct 23, 2022
@aklomp
Copy link
Owner

aklomp commented Oct 23, 2022

I don't have any hardware that supports AVX512, and CI also does not support it. The only way I can run the codec is under an emulator (Intel SDE). Otherwise I would have found this, and probably also added an optimized inline asm implementation.

Will fix.

@mayeut
Copy link
Contributor Author

mayeut commented Oct 24, 2022

I use SDE as well (in CI also) to check for some "check SIMD capability" code. Having the hardware wouldn't have helped in this case.
I don't know of a tool that can help for this one. I had hoped SDE could clear some XCR0 bits on demand to emulate lack of OS support but it seems it can't.

@lucshi
Copy link
Contributor

lucshi commented Nov 29, 2022

The check for OS support has not been updated & still only checks for AVX support. AVX512 added masks, 512-bit register size & 16 new registers. There are 3 corresponding bits that need to be checked in XCR0.

Hi Matthieu,
May I know which OS configuration may break this detection? I ever tested this code on HW (Icelake avx512 + ubuntu) and saw the detection was OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants