Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in translations with :type added, created, updated #1257

Open
exomarty opened this issue Feb 13, 2020 · 8 comments
Open

Problem in translations with :type added, created, updated #1257

exomarty opened this issue Feb 13, 2020 · 8 comments

Comments

@exomarty
Copy link

Please, submit only real issues. Use the forum for support, feature requests, proposals, new versions, help etc. https://akaunting.com/forum

Steps to reproduce the issue

In spanish article and invoice have different genres so verbs need to be in concordance with that.
using the same translation for the notification :type added :type updated etc makes imposible to set a correct translation for both variables

Expected result

be able to set different translation to each variable

Actual result

if you set correct translation in masculine verb to article it will set masculine to invoice that in spanish is femenine

System information (Akaunting, PHP versions)

cliud Versión 2.0.1

Additional comments

please duplicate variables for different notifications so we can translate it correct

@exomarty exomarty changed the title :type added created problem Problem in translations with :type added, created, updated ... Feb 13, 2020
@denisdulici
Copy link
Member

Marty, can you please give us some comparative examples in English and Spanish?

@exomarty
Copy link
Author

Marty, can you please give us some comparative examples in English and Spanish?

yes. here is the example
on english when you create invoice, article etc you get notification
"Invoice created" or "Article created" and is ok because english doesnt change verbs based on the noun gender.

in spanish invoice is "Factura" and article is "Articulo" and you get
"Articulo creado" "Factura creado"

"Articulo creado" is correct because "articulo" is male gender.
but correct form for "Factura creado" is "Factura creada" because "factura" is female gender
so you cant use the same translation variable for both

@denisdulici denisdulici changed the title Problem in translations with :type added, created, updated ... Problem in translations with :type added, created, updated, etc Feb 18, 2020
@denisdulici denisdulici changed the title Problem in translations with :type added, created, updated, etc Problem in translations with :type added, created, updated Feb 18, 2020
@denisdulici
Copy link
Member

OK, now I see the problem with gender, applicable for Albanian too 😉 https://en.wikipedia.org/wiki/Grammatical_gender

Tagged the change for 2.1 version.

@Formatado
Copy link

Same with Portuguese language.
Not only with :types but with other words too, like new. In english new is ok for everything (payments, invoices, bills etc) but in Portuguese its different, we use novo for male words (payment, vendor, costumer etc) and nova for female (invoice, bill, account etc)

@denisdulici denisdulici removed this from the 2.1.0 milestone May 10, 2020
@dadeke
Copy link
Contributor

dadeke commented Jun 11, 2022

Same with Portuguese language. Not only with :types but with other words too, like new. In english new is ok for everything (payments, invoices, bills etc) but in Portuguese its different, we use novo for male words (payment, vendor, costumer etc) and nova for female (invoice, bill, account etc)

Maybe that is a possible solution. It creates redundancie words, but it works.

A example here:
dadeke@7396d7e

But I don't know what the impact of that change would be, because that is complex. 🤔

@dadeke
Copy link
Contributor

dadeke commented Jun 12, 2022

That other project is a good reference:

English 🇬🇧

https://github.com/monicahq/monica/blob/main/resources/lang/en-GB/people.php#L481

    'life_event_sentence_new_instrument' => 'Learned a new instrument',

https://github.com/monicahq/monica/blob/main/resources/lang/en-GB/journal.php#L13

    'journal_add' => 'Add a journal entry',

Spanish 🇪🇸

https://github.com/monicahq/monica/blob/main/resources/lang/es/people.php#L481

    'life_event_sentence_new_instrument' => 'Aprendió un nuevo instrumento',

https://github.com/monicahq/monica/blob/main/resources/lang/es/journal.php#L13

    'journal_add' => 'Agregar una entrada de diario',

Portuguese 🇧🇷

https://github.com/monicahq/monica/blob/main/resources/lang/pt-BR/people.php#L481

    'life_event_sentence_new_instrument' => 'Aprendeu um novo instrumento',

https://github.com/monicahq/monica/blob/main/resources/lang/pt-BR/journal.php#L13

    'journal_add' => 'Adicionar uma entrada no diário',

But I can't assess what the impact of that change on the others consolidated translations on Crowdin and with addition of more words. 💲📈👀

Maybe a good strategy would be to add a little bit of words every now and then and to do the monitoring. Can I make a little pull request? 🙂

@denisdulici
Copy link
Member

Yeah, it will require lots of new language strings, so we've postponed it. Just skip this for now.

@dadeke
Copy link
Contributor

dadeke commented Nov 8, 2023

A workaround that allows you to replace some the official translation without editing its core:

https://github.com/dadeke/akaunting-module-custom-translation

It has a bit impact on performance, but can be useful for some use cases. 🤷🏻‍♂️

This will be archived when there is new language strings. 🙂👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants