Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXE-3763 Found some missing fields in Create ClientLists API request #202

Open
jbattock opened this issue Apr 4, 2024 · 1 comment
Open

Comments

@jbattock
Copy link

jbattock commented Apr 4, 2024

Hi,

Found there are some missing fields in the create client list items object, on the docs ListId & Type are possible, but missing in the Go Code

Have added the diff below which might address it.

Cheers, James

diff --git a/pkg/clientlists/client_list.go b/pkg/clientlists/client_list.go
index 2ac065a..fa8197a 100644
--- a/pkg/clientlists/client_list.go
+++ b/pkg/clientlists/client_list.go
@@ -114,6 +114,8 @@ type (
        // ListItemPayload contains item's editable fields to use as update/create/delete payload
        ListItemPayload struct {
                Value          string   `json:"value"`
+               ListID         string   `json:"listId"`
+               Type           string   `json:"type"`
                Tags           []string `json:"tags"`
                Description    string   `json:"description"`
                ExpirationDate string   `json:"expirationDate"`
@lsadlon
Copy link

lsadlon commented Apr 4, 2024

Hi @jbattock,

Thank you for raising this issue. We will get back to you after investigation.

BR,
Lukasz

@lsadlon lsadlon changed the title Found some missing fields in Create ClientLists API request DXE-3763 Found some missing fields in Create ClientLists API request Apr 4, 2024
@aka-mark aka-mark added the STG label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants