Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quit using q, how to do it now that register_custom_handler is gone? #98

Open
kootenpv opened this issue Jan 29, 2023 · 7 comments
Open
Assignees

Comments

@kootenpv
Copy link

kootenpv commented Jan 29, 2023

Is there a way to achieve it?

I used to be able to do this:

picker.register_custom_handler(ord("q"), lambda _: sys.exit(0))

@antonc42
Copy link

I would also like to know why this feature was removed and if there is a way to re-implement it. It was extremely useful being able to add custom actions for keys. The removal of this feature has made this module all but unusable for me.

@bluenote10
Copy link

Same here. From a UX perspective, the selection gives the feeling of being locked in. I'm instinctively pressing q or ESC all the time, so having some means of aborting would be really nice.

@kootenpv
Copy link
Author

kootenpv commented Mar 4, 2023

Yup still hoping for the return of q

@FelixFourcolor
Copy link

I support this proposal

@kootenpv
Copy link
Author

@wong2 perhaps rolling back to the earlier version is an option? why was there an upgrade that removed perfect functionality?

@FelixFourcolor
Copy link

FelixFourcolor commented Apr 28, 2023

I just created a fork that enables quitting with q, and is currently in pull request.

@LeLunZ
Copy link

LeLunZ commented Mar 29, 2024

Same. I am also wondering why such important functionality was removed?

@aisk aisk self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants