Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs flicker on load #112

Open
nfcampos opened this issue May 15, 2017 · 1 comment
Open

Tabs flicker on load #112

nfcampos opened this issue May 15, 2017 · 1 comment

Comments

@nfcampos
Copy link
Contributor

the tab bar items flicker on load when using a tabs screen, see movie on the url for details

I'd guess it's due to using animated: true https://github.com/airbnb/native-navigation/blob/master/lib/ios/native-navigation/ReactTabBarController.swift#L167 here,

https://www.dropbox.com/s/oxdi8t1r2fmqmie/native-navigation%20tabs%20flicker%20bug.m4v?dl=0

@benkraus
Copy link
Contributor

benkraus commented Jun 1, 2017

So. I actually have done something that I think would fix this problem. In our in-house native navigation lib where I work, we ended up doing something tricky, where we essentially did 1 ish renders of the screen components. I say "ish" because it does a dumb render first where it doesn't render anything, only to get the props (such as the tab item config), then kicks off a full render after it has the basic props.

That may fix this issue here. I'll have to play around with it and see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants