Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDLight branch #470

Open
ghost opened this issue Nov 20, 2020 · 8 comments
Open

TDLight branch #470

ghost opened this issue Nov 20, 2020 · 8 comments
Labels
new feature Missing feature

Comments

@ghost
Copy link

ghost commented Nov 20, 2020

Is your feature request related to a problem? Please describe.
A specific branch for https://github.com/tdlight-team/tdlight-telegram-bot-api/ - fork of botapi
Its features - https://github.com/tdlight-team/tdlight-telegram-bot-api#tdlight-features

Describe the solution you'd like
A specific branch would be fine.

Describe alternatives you've considered
Not relevant

Additional context
None

@evgfilim1 evgfilim1 added the new feature Missing feature label Dec 4, 2020
@MasterGroosha
Copy link
Contributor

MasterGroosha commented Dec 9, 2020

To consider: should TDLight branch have the same version as aiogram? e.g. "2.11.3" and "2.11.3-tdl"
OR
Should it have some different naming, so it can be updates asynchronously, e.g. "2.11.3" and "tdlight-1.0"?

@evgfilim1
Copy link
Contributor

evgfilim1 commented Dec 9, 2020

@MasterGroosha I think it'll be better to combine versioning like this: 2.11.3-tdl.0 < 2.11.3-tdl.1 (patch specific for tdlight) < 2.11.4-tdl.0 (new aiogram version)
But this approach doesn't really allow us to make breaking changes to tdlight only

@MasterGroosha
Copy link
Contributor

@evgfilim1 can we move this discussion to "Discussions"?

@evgfilim1
Copy link
Contributor

@evgfilim1 can we move this discussion to "Discussions"?

If you have more to discuss, then why not

@JrooTJunior
Copy link
Member

I dont think it should be different branch of aiogram. I'd like idea of creating an extension as separated package and different releases schedule.

Something like aiogram-tdlight package which contains TdlightBot class with new methods and types.

@andrew-ld
Copy link

https://github.com/tdlight-team/tdlight-telegram-bot-api/blob/gh-pages/tdlight-api-openapi.yaml

you can easily generate tdlight bot api objects using the open api schema

@JosXa
Copy link

JosXa commented Jan 12, 2021

Does this also concern the new user mode?

@andrew-ld
Copy link

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Missing feature
Projects
None yet
Development

No branches or pull requests

5 participants