message.get_url() in chat with topics -> wrong url

[Robotvasya]

aiogram version

3.x

Problem

The method message.get_url() returns wrong url when it call in chat with topics:
Returns https://t.me/username/message_id but should https://t.me/username/message_thread_id/message_id

aiogram/aiogram/types/message.py

Line 3750 in acf52f4

def get_url(self, force_private: bool = False) -> Optional[str]:

I have not checked whether there is such a problem in other methods of the Message object. And I haven’t checked whether this method is used in other parts of the aiogram framework.

Possible solution

possible patch

--- a/.venv/lib/python3.10/site-packages/aiogram/types/message.py	
+++ b/.venv/lib/python3.10/site-packages/aiogram/types/message.py	(date 1712428103364)
@@ -3765,8 +3765,13 @@
             else self.chat.username
         )
 
+        message_value = (
+            f"{self.message_id}"
+            if not self.message_thread_id
+            else f"{self.message_thread_id}/{self.message_id}"
+        )
 
-        return f"https://t.me/{chat_value}/{self.message_id}"
+        return f"https://t.me/{chat_value}/{message_value}"
 
     def react(
         self,

Alternatives

No response

Code example

No response

Additional information

No response

[Olegt0rr]

Why don't you send a PR?

Looks like it should be able to take both urls: within topic and within all group

[Robotvasya]

I'll send PR, no problem. I'm afraid that this behavior not only in this function but also remains somewhere else.