Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use email.message.EmailMessage for received emails #377

Open
bebleo opened this issue Jun 19, 2023 · 1 comment
Open

Use email.message.EmailMessage for received emails #377

bebleo opened this issue Jun 19, 2023 · 1 comment
Labels
tech-debt Things that needs to be tidied up to avoid being bitten in the future...
Milestone

Comments

@bebleo
Copy link

bebleo commented Jun 19, 2023

Currently aiosmtpd uses email.message.Message to represent a received email. Since version 3.6 (I believe) the preferred class according to python documentation is email.message.EmailMessage.

Making this change would bring aiosmtpd in line with the supported versions of python (currently >= 3.7). It would, however, be a breaking change.

My quick look at the code suggests that the only changes needed to accomplish this would be modifications to:

  • handlers.Message
  • handlers.Mailbox
@pepoluan
Copy link
Collaborator

Making this change would bring aiosmtpd in line with the supported versions of python (currently >= 3.7). It would, however, be a breaking change.

We will implement this in 2.0 then, not in the current major version lineage 😊

@pepoluan pepoluan added this to the 2.0 milestone Oct 23, 2023
@pepoluan pepoluan added the tech-debt Things that needs to be tidied up to avoid being bitten in the future... label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Things that needs to be tidied up to avoid being bitten in the future...
Projects
None yet
Development

No branches or pull requests

2 participants