Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setuid called to early #304

Open
FransSchippers opened this issue Aug 5, 2022 · 0 comments · May be fixed by #369
Open

setuid called to early #304

FransSchippers opened this issue Aug 5, 2022 · 0 comments · May be fixed by #369

Comments

@FransSchippers
Copy link

When requesting a system port (127.0.0.1:25) the setuid call is to early. It should be after the listen is completed. In that way a system port can be open and the program can run at a lower security level.

$ sudo python3 -m aiosmtpd -l 127.0.0.1:25
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/aiosmtpd/__main__.py", line 7, in <module>
    main()
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/aiosmtpd/main.py", line 276, in main
    server_loop = loop.run_until_complete(server)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/asyncio/base_events.py", line 641, in run_until_complete
    return future.result()
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/asyncio/base_events.py", line 1493, in create_server
    raise OSError(err.errno, 'error while attempting '
PermissionError: [Errno 13] error while attempting to bind on address ('127.0.0.1', 25): permission denied
nim-odoo added a commit to nim-odoo/aiosmtpd that referenced this issue Feb 9, 2023
@nim-odoo
Delay UID change after loop start
d4c0962 
Listening to a port < 1024 without `--nosetuid` leads to a permission
error.

The UID change is done too early: we should first open the port, then
change the UID.

Fixes aio-libs#304
@nim-odoo nim-odoo linked a pull request Feb 9, 2023 that will close this issue
Open
10 tasks
nim-odoo added a commit to nim-odoo/aiosmtpd that referenced this issue Feb 9, 2023
@nim-odoo
Delay UID change after loop start
91a2322 
Listening to a port < 1024 without `--nosetuid` leads to a permission
error.

The UID change is done too early: we should first open the port, then
change the UID.

Fixes aio-libs#304
nim-odoo added a commit to nim-odoo/aiosmtpd that referenced this issue Mar 7, 2023
@nim-odoo
Delay UID change after loop start
be6e707 
Listening to a port < 1024 without `--nosetuid` leads to a permission
error.

The UID change is done too early: we should first open the port, then
change the UID.

Fixes aio-libs#304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delay UID change after loop start nim-odoo/aiosmtpd
1 participant
@FransSchippers