Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session.login_data is deprecated #347

Open
bt90 opened this issue Dec 22, 2022 · 1 comment
Open

Session.login_data is deprecated #347

bt90 opened this issue Dec 22, 2022 · 1 comment
Labels
deprecation tech-debt Things that needs to be tidied up to avoid being bitten in the future...
Milestone
1.5

Comments

@bt90
Copy link

bt90 commented Dec 22, 2022

The following warning is logged with aiosmptd 1.4.2 and 1.4.3:

WARNING:mail.log:Session.login_data is deprecated and will be removed in version 2.0

As mentioned by @YoRyan, Mailrise does not use the legacy authentication mechanism:

YoRyan/mailrise#39 (comment)
@pepoluan
Copy link
Collaborator

Thanks! It seems that in the plan of deprecating session.login_data, aiosmtpd itself does inadvertently use a deprecated feature.

Will try to fix that for 1.5.0.

@pepoluan pepoluan added this to the 1.5 milestone Dec 23, 2022
@pepoluan pepoluan added tech-debt Things that needs to be tidied up to avoid being bitten in the future... deprecation labels Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation tech-debt Things that needs to be tidied up to avoid being bitten in the future...
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
2 participants
@pepoluan @bt90