New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authenticated_relayer example closes port immediately #333

Open

obadz opened this issue Dec 18, 2022 · 1 comment

obadz commented Dec 18, 2022

I think it's because of the cont.stop() in the finally block?

aiosmtpd/examples/authenticated_relayer/server.py

Lines 86 to 89 in 330e9ef

    
           try: 
        
               cont.start() 
        
           finally: 
        
               cont.stop()

(Using aiosmtpd 1.4.2)

obadz changed the title ~~authenticated_relayer example terminates immediately~~ authenticated_relayer example closes port immediately

remram44 commented Apr 13, 2023 •

edited

Same remark.

Also it does NOT REQUIRE AUTHENTICATION, which is a huge problem. People will base their code off of this and run in the most insecure way.

edit: opened #374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment