You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's easy to unintentionally overwrite the default total timeout value when changing another, more specific, client timeout:
timeout = ClientTimeout()
print(timeout.total) # 300, default value
timeout = ClientTimeout(connect=5.0)
print(timeout.total) # None, default value is lost
ClientTimeout.total should be preserved when any other timeout is changed, but the total timeout value is not explicitly specified.
Describe the solution you'd like
As suggested in the original discussion, the default 5-minute timeout value should be set directly in the ClientTimeout class, not later in the ClientSession.
Describe alternatives you've considered
An alternative solution could've been changing the documentation and describing the behavior there, leaving the responsibility to explicitly specify the total timeout value to the user.
Related component
Client
Additional context
The issue is created in preparation for the PR.
Code of Conduct
I agree to follow the aio-libs Code of Conduct
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem?
Original discussion #7268
It's easy to unintentionally overwrite the default total timeout value when changing another, more specific, client timeout:
ClientTimeout.total
should be preserved when any other timeout is changed, but the total timeout value is not explicitly specified.Describe the solution you'd like
As suggested in the original discussion, the default 5-minute timeout value should be set directly in the
ClientTimeout
class, not later in theClientSession
.Describe alternatives you've considered
An alternative solution could've been changing the documentation and describing the behavior there, leaving the responsibility to explicitly specify the total timeout value to the user.
Related component
Client
Additional context
The issue is created in preparation for the PR.
Code of Conduct
The text was updated successfully, but these errors were encountered: