Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes there's a gap between the left and right sides #2

Open
aheze opened this issue Sep 27, 2022 · 1 comment
Open

Sometimes there's a gap between the left and right sides #2

aheze opened this issue Sep 27, 2022 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@aheze
Copy link
Owner

aheze commented Sep 27, 2022 •
edited

Sometimes a gap appears:

Normal Gap
Screen Shot 2022-09-27 at 9 59 12 AM Screen Shot 2022-09-27 at 9 59 09 AM

The gap sometimes gets more pronounced when animating the tilt.

This is probably due this rotationEffect here:

Screen Shot 2022-09-27 at 10 07 16 AM

We need to find a way for the tiltRight function to apply that rotation effect too, instead of splitting it into two.

Prism/Sources/PrismEffect.swift

Line 61 in 6879fdd

CGAffineTransform(a: tilt, b: tilt + (1 - tilt), c: 0, d: 1, tx: 0, ty: 0)

@aheze aheze added bug Something isn't working help wanted Extra attention is needed labels Sep 27, 2022
@aheze
Copy link
Owner Author

aheze commented Sep 27, 2022

Happens in the slime demo too:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aheze