Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support thrift for ARM64 #13

Open
khasim opened this issue Aug 29, 2018 · 3 comments
Open

Support thrift for ARM64 #13

khasim opened this issue Aug 29, 2018 · 3 comments

Comments

@khasim
Copy link

khasim commented Aug 29, 2018

Hi,

With very minor changes to Dockerfile, by to moving to latest Debian release "stretch", thrift works on ARM64 containers.

Can you please review the below changes and suggest if I can raise a PR ? Also, can we plan to officially release the binaries for ARM64 on hub.docker ?

`diff --git a/0.11/Dockerfile b/0.11/Dockerfile
index a98ed4f..85fda66 100644
--- a/0.11/Dockerfile
+++ b/0.11/Dockerfile
@@ -1,4 +1,4 @@
-FROM debian:wheezy
+FROM debian:stretch
LABEL authors="Adam Hawkins hi@ahawkins.me"

ENV THRIFT_VERSION 0.11.0
@@ -31,7 +31,11 @@ RUN buildDeps="
&& make install
&& cd /
&& rm -rf /usr/src/thrift \

remove

  && curl -k -sSL "https://storage.googleapis.com/golang/go1.4.linux-amd64.tar.gz" -o go.tar.gz 

replace with

   && if [ $(uname -m) = "aarch64" ]; then \
      curl -k -sSL "https://storage.googleapis.com/golang/go1.10.1.linux-arm64.tar.gz" -o go.tar.gz ; \
      else \
      curl -k -sSL "https://storage.googleapis.com/golang/go1.4.linux-amd64.tar.gz" -o go.tar.gz ; \
   fi \

`

@lag-linaro
Copy link

I just tested Thrift on an AArch64 platform and it appears to work.

Could we please add AArch64 support into the Official Image?

@lag-linaro
Copy link

@ahawkins what is the plan for this repo?

All appears to have gone very quiet.

@ahawkins
Copy link
Owner

ahawkins commented Sep 21, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants