Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve how to handle missed intervals #29

Open
awestendorf opened this issue Oct 25, 2013 · 0 comments
Open

Resolve how to handle missed intervals #29

awestendorf opened this issue Oct 25, 2013 · 0 comments

Comments

@awestendorf
Copy link
Member

There's a disconnect in how missed intervals are handled in the reading functions. For example, MongoBackend._series does this:

for record in cursor:
  while buckets and buckets[0] < record['interval']:
    rval[ config['i_calc'].from_bucket(buckets.pop(0)) ] = self._type_no_value()

The problem here is that _type_no_value assumes the default type for that timeseries, but when using custom read functions, these filler values don't necessarily match the type that the user-provided functions are assuming.

This would also clear up issues with custom read functions, such as in this case where interval is necessary in the return data, but not strictly necessary to satisfy the goals of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant