New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method send4Direct always return false (don't work) #54
Comments
I agree with that. I think an even better souloution could be to check for OPEN: if (self.socket.readyState === self.readyStateConstants.OPEN) {
self.fireQueue();
return true;
} else {
return false;
} I could provide a pull request If you agree with this fix |
Please make a pull request. |
raugaral
added a commit
to raugaral/angular2-websocket
that referenced
this issue
Feb 16, 2017
Method send4Direct always return false (don't work)
Pull request |
afrad
pushed a commit
that referenced
this issue
Feb 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue in
if (self.socket.readyState !== self.readyStateConstants.RECONNECT_ABORTED) { return false; } else { self.fireQueue(); return true; }
When the connection is open:
- self.socket.readyState is 1
- self.readyStateConstants.RECONNECT_ABORTED is 4
self.fireQueue(); - never run
I think it should be like
if (self.socket.readyState === self.readyStateConstants.RECONNECT_ABORTED)
The text was updated successfully, but these errors were encountered: