Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Angular Dependencies #104

Open
MichaelMalony opened this issue Apr 30, 2018 · 0 comments
Open

Update Angular Dependencies #104

MichaelMalony opened this issue Apr 30, 2018 · 0 comments

Comments

@MichaelMalony
Copy link

Any chance we could get the Angular peer dependencies upped to build with Angular 5+ without npm warnings?

Maybe something like:

"@angular/common": ">= 4.4.6 <= 5.x.x",
"@angular/compiler": ">= 4.4.6 <= 5.x.x",
"@angular/core": ">= 4.4.6 <= 5.x.x"

These are the warnings I currently get when using Angular 5:

npm WARN angular2-websocket@0.9.6 requires a peer of @angular/common@^4.4.6 but none is installed. You must install peer dependencies yourself.
npm WARN angular2-websocket@0.9.6 requires a peer of @angular/compiler@^4.4.6 but none is installed. You must install peer dependencies yourself.
npm WARN angular2-websocket@0.9.6 requires a peer of @angular/core@^4.4.6 but none is installed. You must install peer dependencies yourself.

We've been using with Angular 5 without issue (though the websocket usage is by no means exhaustive).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant