2.4.0.RELEASE #532
Replies: 22 comments
-
|
Hi Anastasiia, Brian just saw that the pom.xml still says it's the 2.3.5 release. Can you update that? Ronen |
Beta Was this translation helpful? Give feedback.
-
|
Yes, forgot that. Sorry! |
Beta Was this translation helpful? Give feedback.
-
|
Brian ran into a unit test failure: Should he publish it or wait for you to look into it? |
Beta Was this translation helpful? Give feedback.
-
|
was is from regular mvn clean install? |
Beta Was this translation helpful? Give feedback.
-
|
Yes. mvn clean was performed, then mvn install. |
Beta Was this translation helpful? Give feedback.
-
|
This is very strange, as the test creates needed index. Anyway I've added retry for the index creation in this commit: 11e88aa (all builds are green on GA: https://github.com/aerospike-community/spring-data-aerospike/actions) Hope it helps. |
Beta Was this translation helpful? Give feedback.
-
|
Hi Anastasiia, Brian keeps hitting tests failing (I'll quote the latest below), which is pretty time consuming (and frustrating) for him. I'm not sure what is going on. In the past the reactor client had tests failing on our end when run against a cluster with more than one node. I don't know if that's the case here, but maybe something to explore. Regardless of this specific issue, I'd like for you to switch to building and publishing through GitHub, which will shorten any delays for releases. Here's the error he's seeing: |
Beta Was this translation helpful? Give feedback.
-
|
I will switch to Github Packages shortly, no worries. |
Beta Was this translation helpful? Give feedback.
-
|
Meanwhile the build can be pushed with |
Beta Was this translation helpful? Give feedback.
-
|
Are you testing an aerospike cluster of instances or just a single instance. In the past this was the difference and why the build failed (and would have failed if deployed) |
Beta Was this translation helpful? Give feedback.
-
|
I think that was with the reactor client, right @BrianNichols |
Beta Was this translation helpful? Give feedback.
-
|
we are using this version of docker image in tests - https://github.com/testcontainers/testcontainers-spring-boot/blob/develop/embedded-aerospike/src/main/java/com/playtika/test/aerospike/AerospikeProperties.java#L39 But i still wonder why it works on GitHub actions and on our local machines |
Beta Was this translation helpful? Give feedback.
-
|
It looks like you can either have a cluster of aerospike servers or a single one private void registerAerospikeEnvironment(GenericContainer aerospike,
ConfigurableEnvironment environment,
AerospikeProperties properties) {
Integer mappedPort = aerospike.getMappedPort(properties.port);
String host = aerospike.getContainerIpAddress();
LinkedHashMap<String, Object> map = new LinkedHashMap<>();
map.put("embedded.aerospike.host", host);
map.put("embedded.aerospike.port", mappedPort);
map.put("embedded.aerospike.namespace", properties.namespace);
log.info("Started aerospike server. Connection details {}", map);
MapPropertySource propertySource = new MapPropertySource("embeddedAerospikeInfo", map);
environment.getPropertySources().addFirst(propertySource);
}I know before, with the reactor client, the issue was not testing in a cluster configuration (with more than one aerospike db instance). I am sorry if I am understanding this wrong, but I think you are providing a single seed host which would be used to form a cluster if other aerospike dbs with the same cluster (or no cluster name) name were found. |
Beta Was this translation helpful? Give feedback.
-
|
I'm running spring-data-aerospike unit tests on MacOS 10.12. Docker Desktop Community 2.0.0.3 is also running in the background. The commands I run are:
The IndexedQualifierTests fail as shown in previous post. Do I need to change any configuration before running these commands? I will go ahead and release 2.4.0.RELEASE now. |
Beta Was this translation helpful? Give feedback.
-
|
well if you have docker running, you should be fine... Ok, we will try to investigate this case deeper, meanwhile and you attach full logs of your maven package run? |
Beta Was this translation helpful? Give feedback.
-
|
The full log is included below: $ mvn clean . ____ _ __ _ _ 2020-07-22 16:03:28.527 INFO 16355 --- [ main] .c.AerospikeCacheManagerIntegrationTests : No active profile set, falling back to default profiles: default [ERROR] selectOnIndexedNumericEQQualifier Time elapsed: 10.632 s <<< ERROR! [ERROR] selectOnIndexedLTQualifier Time elapsed: 10.65 s <<< ERROR! [ERROR] selectOnIndexedGTQualifier Time elapsed: 10.697 s <<< ERROR! [ERROR] selectOnIndexedLTEQQualifier Time elapsed: 10.684 s <<< ERROR! [ERROR] selectWithAndQualifier Time elapsed: 10.619 s <<< ERROR! [ERROR] selectWithQualifiersOnly Time elapsed: 10.626 s <<< ERROR! [ERROR] selectOnIndexFilterNonExistingKeys Time elapsed: 10.605 s <<< ERROR! [ERROR] selectOnIndexedGTEQQualifier Time elapsed: 10.633 s <<< ERROR! [INFO] Running org.springframework.data.aerospike.query.QualifierRegexpBuilderTest |
Beta Was this translation helpful? Give feedback.
-
|
I did exactly as @BrianNichols did and had exactly the same errors. I am on Ubuntu 20.04 bare metal (with docker login). |
Beta Was this translation helpful? Give feedback.
-
|
Thank you. I will add docker container logs to the tests output. Probably it will give some clues. |
Beta Was this translation helpful? Give feedback.
-
|
I've just asked my colleagues to run the tests, all are green. I suspect this might be either older version of macos, older version of docker or too low timeouts for index creation for your machine. |
Beta Was this translation helpful? Give feedback.
-
|
I've enabled logging for aerospike container. Brian could you please run the tests and give me the tests output? It would be very helpful! |
Beta Was this translation helpful? Give feedback.
-
|
The test output is 10,000 lines long and I couldn't attach the file in this discussion, so I created an issue in the spring-data-aerospike repository and attached the file there. |
Beta Was this translation helpful? Give feedback.
-
|
Thank you Brian. This was really helpful, sorry for bothering you. |
Beta Was this translation helpful? Give feedback.
-
Hi!
Could you please release spring-data 2.4.0.RELEASE?
Sorry, didn't have a chance yet to dig into release process :(
BR
Anastasiia
Beta Was this translation helpful? Give feedback.
All reactions