Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.c4builder keeps getting updated with every change making it hard to check in to Git #68

Open
vithun opened this issue Jul 15, 2022 · 4 comments

Comments

@vithun
Copy link

vithun commented Jul 15, 2022

I thought it would be a good idea to have .c4builder checked into version control. That way, other team members all work with the same configuration.

However, this means the file keeps getting updated with every change because of the checksums that get written to it. So everyone needs to remember to commit this file with every change in a different image.

Also checksums seem to vary between operating systems (to be confirmed). I have one anecdotal evidence of my colleague's Windows machine generating a different checksum compared to my Mac.

Can we move the checksums to a separate file that can be safely .gitignored and keep the .c4builder file easy to maintain in version control?

@vithun
Copy link
Author

vithun commented Jul 15, 2022

It seems like there was historically a separate file for checksums: bc475c5?w=1

Was there a reason this was moved to the main configuration file?

@vithun
Copy link
Author

vithun commented Jul 15, 2022

If you are ok with moving checksums back to a separate file, I can create a PR with the change.

@vithun vithun closed this as completed Jul 17, 2022
@vithun
Copy link
Author

vithun commented Jul 28, 2022

This somehow got closed because I mentioned the issue in a different pull request. Reopening.

@vithun vithun reopened this Jul 28, 2022
@bugfest
Copy link

bugfest commented Aug 10, 2022

Hi @vithun. I faced the same issue : )

I opened a PR (#72) to keep track of the image checksums in a different file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants