Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need a block config? #30

Open
rofe opened this issue Nov 4, 2021 · 0 comments
Open

Do we need a block config? #30

rofe opened this issue Nov 4, 2021 · 0 comments
Labels
question Further information is requested

Comments

@rofe
Copy link
Contributor

rofe commented Nov 4, 2021

In scripts.js, there's a selector block config with paths, script and style filenames. It allows loading a block for any element matching the selector, and avoids loading non-existent files (e.g. if a block only consists of a CSS file).

But it also adds complexity, reduces modularity (blocks need to be registered in scripts.js), which requires a trade-off.

@rofe rofe added the question Further information is requested label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant