From b42f522a294615f44389da32c6cf0aeae3080565 Mon Sep 17 00:00:00 2001 From: Ashish Kayastha Date: Fri, 8 Mar 2024 11:26:06 -0600 Subject: [PATCH 1/2] chore: Added logging statements 'Edit Prompt' and 'Preview' buttons --- web-src/src/components/PromptEditor.js | 13 ++++++++++--- web-src/src/components/PromptSessionPanel.js | 9 ++++++++- web-src/src/components/PromptSessionSideView.js | 1 - 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/web-src/src/components/PromptEditor.js b/web-src/src/components/PromptEditor.js index d5cc7912..58a2426a 100644 --- a/web-src/src/components/PromptEditor.js +++ b/web-src/src/components/PromptEditor.js @@ -20,13 +20,14 @@ import { useRecoilState, useRecoilValue } from 'recoil'; import { css, injectGlobal } from '@emotion/css'; import { Global } from '@emotion/react'; import { motion, AnimatePresence } from 'framer-motion'; - import Close from '@spectrum-icons/workflow/Close'; -import { NO_VALUE_STRING, renderPrompt } from '../helpers/PromptRenderer.js'; -import PreviewIcon from '../icons/PreviewIcon.js'; import { parametersState } from '../state/ParametersState.js'; import { promptState } from '../state/PromptState.js'; +import { NO_VALUE_STRING, renderPrompt } from '../helpers/PromptRenderer.js'; +import { log } from '../helpers/Tracking.js'; + +import PreviewIcon from '../icons/PreviewIcon.js'; languages.custom = { function: /{{[^@#]([^{}]+)}}/, @@ -107,6 +108,12 @@ function PromptEditor({ isOpen, onClose, ...props }) { } }, [viewSource]); + useEffect(() => { + if (!viewSource) { + log('prompt:editor:previewed'); + } + }, [viewSource]); + const handleKeyDown = useCallback((event) => { if (event.key === 'Escape') { onClose(); diff --git a/web-src/src/components/PromptSessionPanel.js b/web-src/src/components/PromptSessionPanel.js index 87c92e73..babafa06 100644 --- a/web-src/src/components/PromptSessionPanel.js +++ b/web-src/src/components/PromptSessionPanel.js @@ -10,16 +10,23 @@ * governing permissions and limitations under the License. */ import { Flex, Grid } from '@adobe/react-spectrum'; -import React from 'react'; +import React, { useEffect } from 'react'; import { useRecoilState } from 'recoil'; import { PromptSessionSideView } from './PromptSessionSideView.js'; import { PromptResultListView } from './PromptResultListView.js'; import PromptEditor from './PromptEditor.js'; import { promptEditorState } from '../state/PromptEditorState.js'; +import { log } from '../helpers/Tracking.js'; export function PromptSessionPanel() { const [isOpenPromptEditor, setIsOpenPromptEditor] = useRecoilState(promptEditorState); + useEffect(() => { + if (isOpenPromptEditor) { + log('prompt:editor:opened'); + } + }, [isOpenPromptEditor]); + return ( From 91d684b25fad141fe6223cb42340d036a80dd6f8 Mon Sep 17 00:00:00 2001 From: Ashish Kayastha Date: Tue, 12 Mar 2024 15:15:06 -0500 Subject: [PATCH 2/2] fix: Renamed Tracking.js to MetricsHelper.js --- web-src/src/components/PromptEditor.js | 2 +- web-src/src/components/PromptSessionPanel.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/web-src/src/components/PromptEditor.js b/web-src/src/components/PromptEditor.js index 58a2426a..db00dd95 100644 --- a/web-src/src/components/PromptEditor.js +++ b/web-src/src/components/PromptEditor.js @@ -25,7 +25,7 @@ import Close from '@spectrum-icons/workflow/Close'; import { parametersState } from '../state/ParametersState.js'; import { promptState } from '../state/PromptState.js'; import { NO_VALUE_STRING, renderPrompt } from '../helpers/PromptRenderer.js'; -import { log } from '../helpers/Tracking.js'; +import { log } from '../helpers/MetricsHelper.js'; import PreviewIcon from '../icons/PreviewIcon.js'; diff --git a/web-src/src/components/PromptSessionPanel.js b/web-src/src/components/PromptSessionPanel.js index babafa06..d7f50920 100644 --- a/web-src/src/components/PromptSessionPanel.js +++ b/web-src/src/components/PromptSessionPanel.js @@ -16,7 +16,7 @@ import { PromptSessionSideView } from './PromptSessionSideView.js'; import { PromptResultListView } from './PromptResultListView.js'; import PromptEditor from './PromptEditor.js'; import { promptEditorState } from '../state/PromptEditorState.js'; -import { log } from '../helpers/Tracking.js'; +import { log } from '../helpers/MetricsHelper.js'; export function PromptSessionPanel() { const [isOpenPromptEditor, setIsOpenPromptEditor] = useRecoilState(promptEditorState);