Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theseus breaks Polymer #66

Open
AdriVanHoudt opened this issue Sep 6, 2014 · 4 comments
Open

Theseus breaks Polymer #66

AdriVanHoudt opened this issue Sep 6, 2014 · 4 comments

Comments

@AdriVanHoudt
Copy link
Contributor

Since Theseus inserts javascript as first script on the page it breaks the platform.js from Polymer.
See "platform.js is not the first script on the page. See http://www.polymer-project.org/docs/start/platform.html#setup for details."
I assume Theseus also requires to be the first script otherwise it would be nice to no insert it first or make it optional or something.
@alltom
Copy link
Member

alltom commented Sep 8, 2014

Inserting Theseus first is the easiest, most fool-proof way to do it programmatically.

Does it cause problems for Polymer, or does it just trigger a warning?

@AdriVanHoudt
Copy link
Contributor Author

I guessed so and it triggers the warning and causes problems. Some elements stop working.

@alltom
Copy link
Member

alltom commented Sep 10, 2014

Could you give me an example, or will it be obvious if I open a Polymer example project?

@AdriVanHoudt
Copy link
Contributor Author

It is pretty obvious. With Polymer you include platform.js and it should be the first javascript in the head tag. Like this:

<html>
    <head>
        <script src="/bower_components/platform/platform.js"></script>
    ...
    </head>
    ...
</html>

With Theseus on it looks like

<html>
    <head>
        <script>theseus stuff here</script>
        <script src="/bower_components/platform/platform.js"></script>
    </head>
    ...
</html>

If you look at the Sources tab of Chrome dev tools it displays the Theseus script tag even before the html tag.
Also I found that, at least in my version of chrome, it doesn't give the error stated above but it will just give the errors caused by it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alltom @AdriVanHoudt