Sign phase 2 #727
Closed
Sign phase 2 #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMESVCS-330: Implement insert user in Sign Engine
Common engine methods
…ser-sync.py into sign_testcase � Conflicts: � tests/test_sign_engine.py
Merged after taking Update on Sign changes
- connector_sign.py - client.py
This reverts commit e2457c6
refactor and addition of begin_work_sign
DMESVCS-383- updated option
…uring connector init. add comments to connector-sign.yml to instruct users on sign key storage
…or remove_roles option
…cted on in handle_sign_only_users method. add assertions for remove_roles and remove_groups
Port Asyncio Methods from Sign Post Sync to Sign Phase 2
Add config options to remove roles and remove groups for sign-only users
Testing common_engine
Finish merging umapi engine tests
read desired groups umapi
|
Closing this since we don't want to merge to v2 until final release is ready. We'll tag release candidates from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Retool Sign Sync to sync process, moving off of post-sync model to direct sync. We still need documentation, but this should be enough for a release candidate.
Notes
Testing
sign-sync-config.yml(see example)./user-sync sign-syncconnector-sign.yml(see example)Fixes #726