Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up codesigning and ensure signing success #17

Open
Asher- opened this issue Feb 25, 2021 · 9 comments
Open

Clean up codesigning and ensure signing success #17

Asher- opened this issue Feb 25, 2021 · 9 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Asher-
Copy link
Collaborator

Asher- commented Feb 25, 2021

Issues related to dependencies are causing codesign to fail unless deep is specific, which is not recommended.

Sorting this out is rather opaque, so probably requires step by step cleaning up the dependencies.

@Asher- Asher- added the bug Something isn't working label Feb 25, 2021
@Asher- Asher- self-assigned this Feb 25, 2021
@ChrisForsythe ChrisForsythe added this to the Adium 1.6 milestone Feb 25, 2021
@estella144
Copy link
Collaborator

@Asher- Codesign is okay for me (Adium 1.5.10.4 on macOS 11.2.2).

@Asher-
Copy link
Collaborator Author

Asher- commented Mar 9, 2021

I'm not sure what you mean.

This issue concerns deployment of compiled sources to bundle a new Adium.app.

The problem is that the (very old) build scripts create the dylibs and then frameworkerize them without any code signing. When Xcode performs its copy phase and goes to sign the frameworks, it does so by signing the bundled /A file, expecting everything else to already be signed; instead, it finds that nothing is signed and bails.

Adium used to handle this by using --force --deep, but this is improper (and has been clarified as such by Apple more recently) and further did not work properly in all cases.

The proper solution is to codesign the dylibs as they are generated. This is not of itself difficult, but it requires the build scripts to be in working order— which they were not. They are now in mostly working order, with a few further details to be resolved, at which point codesigning can be easily integrated.

The only detail that I am not sure of offhand is how to use Xcode's automatic signing selection from the build script. I'm hoping Google knows.

@estella144
Copy link
Collaborator

@Asher- What I am saying is that the disk image should sign properly on my computer.

@Asher-
Copy link
Collaborator Author

Asher- commented Mar 10, 2021

This concerns signing of the binary, before any disk image is created.

@estella144
Copy link
Collaborator

@Asher- I have no binary, only dmg.

@Asher-
Copy link
Collaborator Author

Asher- commented Mar 10, 2021

Please don't comment on issues you don't understand unless it is to ask pertinent questions that lead to an understanding.

@estella144
Copy link
Collaborator

How do you know I don't understand this?

@Asher-
Copy link
Collaborator Author

Asher- commented Mar 11, 2021

If you understood this, you would be able to identify the evidence yourself.

@estella144
Copy link
Collaborator

@Asher- I don't have the binary to identify the evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants