Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various optimisations #48

Open
ThomasSevestre opened this issue Feb 5, 2021 · 2 comments
Open

Various optimisations #48

ThomasSevestre opened this issue Feb 5, 2021 · 2 comments

Comments

@ThomasSevestre
Copy link
Contributor

I've pushed some optimisations in my eventmachine branch.
They are not eventmachine related, it could be porter here.

The biggest optimisation is very simple :
ThomasSevestre@3aa907e

I also pushed an optimised lexer (50% improvement) :
ThomasSevestre@ad24ff8

@benlangfeld
Copy link
Member

The logging one would need to be conditional. I'd accept a PR for it.

The optimised lexer is probably fine assuming it passes the tests but I don't have time to fully review it. Maybe @lpradovera could.

@ThomasSevestre
Copy link
Contributor Author

I'm using my EM branch everywhere now and I won't be able to provide battle field tested PRs. My branch is based on an old version of the library, there might be small differences.

The optimised lexer passes the tests except for one little change . The test suite is very good by the way.

I've been using my branch in production without issue for over 9 months now. Feel free to cherry-pick what you want. The commit I pointed in my previous message had significant impact on CPU usage, even in an heavy application with a lot of ActiveRecord queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants