Multiple Blather Clients Not Working

[etm]

When multiple blather clients are created in a program only the first one works. All other clients can't connect (never get ready).

2.times do
Thread.new do
EM.run do
client = Blather::Client.setup ...
client.register_handler(:ready) { print ... }
client.connect
end
end
end

[benlangfeld]

You have to run all of them in the same EM reactor for now. I have no
interest in fixing all of EM's nonsense, and much prefer to push forward
with the move to Celluloid. Contributions welcome if you do have a fix for
this, though :)

On 25 March 2014 16:20, eTM notifications@github.com wrote:

When multiple blather clients are created in a program only the first one
works. All other clients can't connect (never get ready).

2.times do
Thread.new do
EM.run do
client = Blather::Client.setup ...
client.register_handler(:ready) { print ... }
client.connect
end
end
end

Reply to this email directly or view it on GitHubhttps://github.com//issues/129
.

[etm]

Hmm, solved it in my code by working around with EM#defer. This is a generic quick & dirty solution for most EM thread problems :-)

2.times do
  Thread.new do
    EM.send EM.reactor_running? ? :defer : :run do
      client = Blather::Client.setup ...
      client.register_handler(:ready) { print ... }
      client.connect
    end
  end
end

But after some quick digging, I think i know what the problem is :-)
It's in lib/blather/stream.rb Stream#self.connect. Please see https://github.com/eventmachine/eventmachine/wiki/FAQ -> "Does EM work with other Ruby threads running?"

When changing self.connect you lose the rescue NoConnection, but you gain proper support for multiple clients.

def self.connect(host, port, conn, client, jid, pass, connect_timeout = nil)
  EM.next_tick do
    EM.connect host, port, conn, client, jid, pass, connect_timeout
  end
end

As users are losing immediate connection problem handling (how many even check?, probably none :-)), something like a :connection_error handler similar to :ready handler would be nice. But one can survive without it - EM#error_handler should catch it too. Maybe an example in the README would suffice.

[ThomasSevestre]

In case somebody is looking for multiple client support. Here is a simple solution :

EM.run do
  2.times do
    client = Blather::Client.setup ...
    client.register_handler(:ready) { print ... }
    client.run
  end
end

A few patches are needed in blather :

• BUG : EM streams messed up when one of many in-script connections closed. #169 (comment)
• ThomasSevestre@ccaee91