OutboundCall#on_end not executed on call failure

[lpradovera]

See logs and code here:
https://gist.github.com/polysics/76c45bdab87638aa2b32#file-gistfile1-txt-L220

The on_end handler defined in Adhearsion is run, while the application-defined one is not.

[benlangfeld]

You register the callback too late. You should do it before OutboundCall#originate.

[system123]

I am experiencing this issue when a call is rejected. This is how the call is originated, yet sometimes if the call is rejected with ISDN code 21 then the on_end event is not triggered. Reproducible with around 25 active calls.

Adhearsion::OutboundCall: ae1363ae-7ed9-43c7-957b-385848347f46@�[0m: Call 27121110512 -> SIP/platforma/0720000035 ended due to reject (code 21)

The call is originated as follows:

def init_outbound(contact_ref)
    @contact_ref = contact_ref
    @route = :outbound
    @call = Adhearsion::OutboundCall.new
    @call[:callee] = self

    # Set the dialplan to execute for this agent
    metadata = {
      campaign: @campaign,
      callee: self,
    }
    @call.execute_controller_or_router_on_answer OutboundCalleeController, metadata
    @call.tag(@call_ref.to_s)

    @call.on_end { |event| callee_ended(event) }

    @dialled_time = Time.now
    @campaign.add_ringing_call @call_ref, @call 
    @call.dial @callee_address, from: @outbound_id
  end