Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/306/feature to add custom package #340

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

spuday90
Copy link
Collaborator

@spuday90 spuday90 commented Jul 9, 2021

CLoses #306

@spuday90 spuday90 requested a review from adeekshith July 9, 2021 03:35
@hegocre
Copy link
Collaborator

hegocre commented Jul 11, 2021

Tried this branch. Here are some problems that I found:

  • Watomatic not detecting the app is installed, although it is (I suppose this is also the reason why the app icon is not shown).
  • Adding the same package name two times results in the app crashing.
  • Changing enabled apps to a custom one does not update the main screen until a restart.

Also some suggestions:

  • Move the option to add packages to the enabled apps screen
  • Add the option to remove a custom package

I can give more info or explain better if something is unclear, let me know!

@spuday90
Copy link
Collaborator Author

Hi @hegocre ,
Thanks for your feedback, ill look into them.

@spuday90
Copy link
Collaborator Author

spuday90 commented Jul 23, 2021

Known issue : Select/Deselect any item and scroll up/down then the state is missing first time - Working on it -- Resolved

  • List segregation/sorting - b8d314b
    - [ ] Show alert dialog when pressed back without saving this is not needed as we are saving on each click

@spuday90
Copy link
Collaborator Author

Screenrecorder-2021-07-23-09-10-31-36.mp4

Screenshot_2021-07-23-09-12-12-970_com parishod watomatic
Screenshot_2021-07-23-09-15-06-022_com parishod watomatic

@adeekshith
Copy link
Owner

@spuday90 Can you also add a warning dialog when floating "+" button is clicked. Something like "Not tested to work with apps in the list and can cause unintended issues. Use at your own risk." With cancel and accept buttons.

@spuday90
Copy link
Collaborator Author

spuday90 commented Jul 23, 2021

@spuday90 Can you also add a warning dialog when floating "+" button is clicked. Something like "Not tested to work with apps in the list and can cause unintended issues. Use at your own risk." With cancel and accept buttons.

Added in abb51ae
Removed "Use at your own risk" its looking as if device can be damaged or so. Feel free to add it if u think is needed
Screenshot_2021-07-26-08-01-50-152_com parishod watomatic

@spuday90
Copy link
Collaborator Author

Screenshot_2021-07-24-12-01-22-916_com parishod watomatic
Changed the UI to be in sync with contact selector

@hegocre
Copy link
Collaborator

hegocre commented Jul 25, 2021

Tested this branch again, everything works right except for the installed apps list, which is weird (see screenshot). I imagine it is because of the rtl approach, so I would suggest using the method shown here, or just using a TextView + Checkbox instead, which I can implement if you are busy.

Screenshot_20210725-121042

@spuday90
Copy link
Collaborator Author

spuday90 commented Jul 26, 2021

Tested this branch again, everything works right except for the installed apps list, which is weird (see screenshot). I imagine it is because of the rtl approach, so I would suggest using the method shown here, or just using a TextView + Checkbox instead, which I can implement if you are busy.

Screenshot_20210725-121042

Hi @hegocre ,
Thanks for reporting the issue. Its behaving differently on different devices.
I'm just checking for any better solution, if couldn't find any will implement what you have suggested i.e using separate textview+checkbox.

Fixed in 6e19f99
@hegocre Please test now

@hegocre
Copy link
Collaborator

hegocre commented Jul 27, 2021

It is fixed indeed. Now I'm facing a couple of issues

Other than that, great work, I think it's nearly working perfectly, and it will be a great addition to Watomatic.

@spuday90
Copy link
Collaborator Author

spuday90 commented Jul 28, 2021

Hi @hegocre,
Yes app not installed is a known issue, Earlier we didn't had the query_all package permission so was not able to detect app. I will fix that.

@hegocre
Copy link
Collaborator

hegocre commented Jul 28, 2021

Nice, tried it with telegram, it works great!

@Goldmaster
Copy link

Is there an eta, of when this will be added? This would also solve quite a few other requests such as support for messenger lite, discord and telegram.

Signed-off-by: hegocre <hegocre@hotmail.com>

# Conflicts:
#	app/src/main/java/com/parishod/watomatic/adapter/SupportedAppsAdapter.kt
#	app/src/main/java/com/parishod/watomatic/fragment/EnabledAppsFragment.kt
#	app/src/main/java/com/parishod/watomatic/fragment/MainFragment.java
#	app/src/main/java/com/parishod/watomatic/model/App.kt
#	app/src/main/java/com/parishod/watomatic/model/utils/CustomDialog.java
#	app/src/main/java/com/parishod/watomatic/model/utils/NotificationHelper.java
#	app/src/main/res/values/strings.xml
@hegocre
Copy link
Collaborator

hegocre commented Nov 23, 2021

Merged main into this to solve merge conflicts, this should be tested. And maybe release a new version? There are some nice changes since the last one.

@adeekshith
Copy link
Owner

Is there an eta, of when this will be added? This would also solve quite a few other requests such as support for messenger lite, discord and telegram.

Main reason for not merging this is Google Play has new policies regarding apps having permission to access entire apps list. We are now required to apply to them separately with justification, etc for this. And then they would scrutinize the app and websites before giving permissions. Some of the apps recently got removed from Play store for having a donation button on the website. Watomatic has that too so need to figure out having an alternative URL for Play Store users which does not show Donation button. It is not clear we are violating Play Store policies but there is a gray area there. Need to clear those bureaucratic hurdles before this can merged

@adeekshith
Copy link
Owner

Merged main into this to solve merge conflicts, this should be tested. And maybe release a new version? There are some nice changes since the last one.

Thank you @hegocre 🙌

Will make a release next week. Thats true, its long overdue 😊
Will merge this PR after the release though because of this:
#340 (comment)

This was referenced Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature to accept package name to enable auto reply for any app
4 participants