-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move atrribution option from editor screen to settings #303
Conversation
|
For fresh install it is working fine |
Checked it on the other PR #305 which has these changes and it is not ON by default |
I see you removed the |
But for the sake of transparency, we can show a preview of how it looks while saving the text and perhaps include the checkbox in the preview. Also, guiding them to the setting in editor screen also is not easy as it requires multiple screenshots and lots of explanation like asking them to lower the keyboard if not visible, etc. Just asking them to check in the settings is easy. Lets see how users take this change and go forward accordingly. I think this is one of those where we feel it is obvious once we already know where it is but rest of the folks are having trouble finding it. One of many messages where users feel "Settings" is the right place for this:
|
Yeah, it could be that!
I think this will be very important in case we finally remove the checkbox. Some users might not check settings and simply enable the app from the main activity, and then find the attribution text is being added. I think that would be very confusing. |
Okay, lets leave the checkbox as-is until we figure out a better way 😊 |
@adeekshith this is happening because on our devices as we have app installed from store its not considering as first install. Please check on other device. |
Seem to be working on the other PR but may need some more UI improvements before merging this. We can keep the branch but lets close this PR until we figure out the UI 😊 |
closes #301