Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Official docker image #262

Open
sheerun opened this issue Dec 9, 2017 · 6 comments · May be fixed by #550
Open

Official docker image #262

sheerun opened this issue Dec 9, 2017 · 6 comments · May be fixed by #550

Comments

@sheerun
Copy link

sheerun commented Dec 9, 2017

Critica's requirements and size is pretty substantial, could you prepare official dockerfile so everyone doesn't need to re-run build of it? Following would be perfect:

FROM node:8

RUN apt-get update && apt-get install -y libnss3 libxss1 libasound2 libpangocairo-1.0-0 libx11-xcb-dev libxcomposite1 libxcursor1 libxdamage1 libxi6 libxtst6 libcups2 libxrandr-dev libgconf-2-4 libatk1.0-0 libgtk-3-0

RUN npm install -g yarn

RUN yarn global add critical@1.1.0

And tag it like critical:1.1.0

This way one would be able to install critical extremely quickly with yarn --prefer-offline within docker.
@zomars
Copy link

zomars commented Jan 19, 2018

I totally agree with this

@gbowne-quickbase
Copy link

In case anyone trips over this page, it looks like @sheerun has built out a docker image:
sheerun/critical
Which is working well for us. Thanks!! I agree that an image appropriately documented as part of this project would be better, but this will get us a long way.

@sheerun
Copy link
Author

sheerun commented Sep 13, 2019

I've just upgraded this image to node 10 and critical 1.3.6

@gablittledevshop
Copy link

Hello, is the docker image still available? I'm running gulp in a docker container and currently I have an error that says, (node:38) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Failed to launch chrome! spawn /tmp/app/node_modules/puppeteer/.local-chromium/linux-637110/chrome-linux/chrome ENOENT. I'm wondering if the docker image will resolve this issue.

@snyk-bot snyk-bot mentioned this issue May 30, 2021
Open
@Subhojit1992 Subhojit1992 mentioned this issue Oct 5, 2022
Open
@dmezquiam
Copy link

Hi, does anyone know how to make it run from a src (URL_FROM_MY_LOCAL_DOCKER), from a local docker instance?

generate({
  inline: true,
  base: 'test/',
  src: URL_FROM_MY_LOCAL_DOCKER
  target: 'index-critical.html',
  width: 1300,
  height: 900,
});

@tmaier tmaier linked a pull request Jan 17, 2023 that will close this issue
Open
@tmaier
Copy link

tmaier commented Jan 17, 2023

I created a new docker image and opened a pull request.

Check out #550 and https://github.com/tmaier/critical/pkgs/container/critical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add docker image tmaier/critical
6 participants
@sheerun @tmaier @zomars @dmezquiam @gbowne-quickbase @gablittledevshop