Setting target option does not write any files ...

[eimfach]

I have these options:

critical.generate({
  inline: true,
  src: 'index.html',
  width: 1300,
  height: 900,
  extract: true,
  base: './',
  target: {
    css: 'critical.css',
    html: 'index-critical.html',
    uncritical: 'uncritical.css'
  },
  ignore: {atrule: ['@charset']}
}).catch(function(err){
  throw err;
})

But it silently does not write any files ...

[bezoerb]

which version of critical are you using?

[eimfach]

1.3.9

[bezoerb]

try installing the 2.x branch with npm i critical@next

[bezoerb]

the documentation for the old version is at https://github.com/addyosmani/critical/tree/1.x

[eimfach]

ah I see, okay thanks, will try that

[eimfach]

Okay it writes the html file now and I changed target to target: 'index-critical.html'.
But it does not create a inline css style tag in the header where the critical css should be ...

[bezoerb]

hmm... that's weird. Can you create a gist to reproduce?

[bezoerb]

@eimfach: Any updates on this?

[lincolnaleixo]

not the OP but your solution to update to 2.0 version worked for me. thanks @bezoerb

[kentr]

I'm seeing the same thing on 4.0.1. In my case I'm using the html option and also outputting a css file, which is empty.

My guess is that critical is not actually generating the critical css, and so there's nothing to put into the html file.

[kentr]

Yeah, I confirmed that there is no generated css by using a callback to log the result.

The err parameter to the callback is null, so no errors to give clues.

Still debugging...

[kentr]

In my case it was due to an old configuration that's no longer supported AFAICT: Passing an html string or a local source file that contains links to remote stylesheets.

This appears to return "empty" stylesheet documents in getStyleseet().

In the debugging, I discovered that remote URLs are supported in the src parameter, but they will fail silently if the certificate is self-signed (such as in a dev environment). The NODE_TLS_REJECT_UNAUTHORIZED environment variable appears to have no effect on got, possibly because critical explicitly defaults to rejectUnauthorized: true.

For me, the solution was to use the actual URL in src instead of a string in html, and to set the request option with

{
  https: {
    rejectUnauthorized: false,
  },
}